feat: add support for ignore_case for in string array #44
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| None => true, | ||
| }, | ||
| } | ||
| .invert(inverted) |
There was a problem hiding this comment.
Not sure if this is standard in rust, or if it's better to keep everything together. Lines started to grow big and this little change made it more readable, but I'm ok moving it back (also for consistency with the other operations)
There was a problem hiding this comment.
Unfortunately that's a logic change here, since this will also flip the state when the context value doesn't exist.
Annoying that neither the existing tests nor the client spec tests picked it up.
This might be more correct but I think it needs a bit more thought than a 5 minute glance
(But also, the code structure is fine, that looks like totally sane Rust to me)
| @@ -8,7 +8,7 @@ Yggdrasil is a Rust project designed to create the core of the Unleash SDK domai | |||
|
|
|||
| ## Building the Core | |||
|
|
|||
| Easy enough - run `cargo build` from the root of the project. You'll need an up to date set of Rust tools to do this. | |||
| Easy enough - run `cargo build` from the root of the project. You'll need an up to date set of Rust tools to do this (`rustup update stable`). | |||
gastonfournier
changed the title
|
This isn't something we need in the grammar right now, so I'm going to let this hang for a bit. The point was a learning exercise |
equals_any_ignore_case)