Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PropositionalFormulaParserTest #132

Merged
merged 2 commits into from
Mar 21, 2024
Merged

Add PropositionalFormulaParserTest #132

merged 2 commits into from
Mar 21, 2024

Conversation

maximilian-glumann
Copy link

@maximilian-glumann maximilian-glumann commented Feb 14, 2024 •
edited
Loading

resolves #104

@maximilian-glumann maximilian-glumann marked this pull request as ready for review February 14, 2024 12:48
@pmbittner pmbittner self-requested a review February 14, 2024 15:38
@pmbittner pmbittner added the enhancement New feature or request label Feb 14, 2024
@pmbittner pmbittner linked an issue Feb 14, 2024 that may be closed by this pull request
Test Propositional Formula Parser #104
Closed
pmbittner
pmbittner reviewed Feb 14, 2024
View reviewed changes
Copy link
Member

@pmbittner pmbittner left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @maximilian-glumann

thank you, the changes look great. Only some minor comments regarding the documentation. We can discuss these comments tomorrow in our meeting. Then we can merge. :)

src/test/java/PropositionalFormulaParserTest.java Show resolved Hide resolved
src/test/java/PropositionalFormulaParserTest.java Outdated Show resolved Hide resolved
src/test/java/PropositionalFormulaParserTest.java Outdated Show resolved Hide resolved
@maximilian-glumann maximilian-glumann force-pushed the issue104-propositional-formula-parser-test branch from fb11b73 to 4ab8d21 Compare March 20, 2024 17:32
@pmbittner pmbittner merged commit 56abb9c into VariantSync:develop Mar 21, 2024
2 checks passed
@maximilian-glumann maximilian-glumann deleted the issue104-propositional-formula-parser-test branch April 23, 2024 21:36
@pmbittner pmbittner mentioned this pull request Apr 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmbittner pmbittner pmbittner left review comments

Assignees

@maximilian-glumann maximilian-glumann

Labels
enhancement New feature or request
Projects
No open projects
SE-Project WT23/24
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test Propositional Formula Parser
2 participants
@maximilian-glumann @pmbittner