Bugfix: Actively reduce memory use in memcache filestore #3935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR forces synchronous writing when memory utilization is exceeded in the memcache filestore. By writing synchronously we can push back against writers to ensure that memory can be cleared before we take on new writes. Previously this flushing was asynchronous which means there was no guarantee that memory was properly flushed - leading to an uncontrolled increase in memory use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR forces synchronous writing when memory utilization is exceeded in the memcache filestore. By writing synchronously we can push back against writers to ensure that memory can be cleared before we take on new writes. Previously this flushing was asynchronous which means there was no guarantee that memory was properly flushed - leading to an uncontrolled increase in memory use.
Fixes: #3906