VCI-128: Fix codesmells (#16)

VirtoCommerce · Aug 19, 2021 · 860e7c3 · 860e7c3
1 parent 72d9ac3
commit 860e7c3
Show file tree

Hide file tree

Showing 8 changed files with 8 additions and 12 deletions.
diff --git a/PlatformTools/AppSettings.cs b/PlatformTools/AppSettings.cs
@@ -3,7 +3,7 @@
 
 namespace PlatformTools
 {
-    internal class AppSettings
+    internal static class AppSettings
     {
         private static IConfiguration _configuration;
 

diff --git a/PlatformTools/Build.PackageManager.cs b/PlatformTools/Build.PackageManager.cs
@@ -201,6 +201,7 @@ private bool NeedToInstallPlatform(string version)
                     if (externalModule == null)
                     {
                         ControlFlow.Fail($"No module {module.Id} found");
+                        return;
                     }
 
                     if (alreadyInstalledModules.Any(installedModule => installedModule.ModuleName == module.Id && installedModule.Version.ToString() == module.Version))

diff --git a/PlatformTools/ExtModuleCatalog.cs b/PlatformTools/ExtModuleCatalog.cs
@@ -10,7 +10,7 @@
 
 namespace PlatformTools
 {
-    internal class ExtModuleCatalog
+    internal static class ExtModuleCatalog
     {
         private static ExternalModuleCatalog _catalog;
 

diff --git a/PlatformTools/GithubManager.cs b/PlatformTools/GithubManager.cs
@@ -6,7 +6,7 @@
 
 namespace PlatformTools
 {
-    internal class GithubManager
+    internal static class GithubManager
     {
         private static readonly string _githubUser = "virtocommerce";
         private static readonly string _platformRepo = "vc-platform";

diff --git a/PlatformTools/LocalCatalog.cs b/PlatformTools/LocalCatalog.cs
@@ -1,4 +1,4 @@
-using Microsoft.Extensions.Logging;
+using Microsoft.Extensions.Logging;
 using Microsoft.Extensions.Options;
 using System;
 using System.Collections.Generic;
@@ -184,11 +184,6 @@ private bool IsAssemblyRelatedFile(string path)
             return _options.AssemblyFileExtensions.Union(_options.AssemblyServiceFileExtensions).Any(x => path.EndsWith(x, StringComparison.OrdinalIgnoreCase));
         }
 
-        private bool IsAssemblyFile(string path)
-        {
-            return _options.AssemblyFileExtensions.Any(x => path.EndsWith(x, StringComparison.OrdinalIgnoreCase));
-        }
-
         private bool IsLocalizationFile(string path)
         {
             return _options.LocalizationFileExtensions.Any(x => path.EndsWith(x, StringComparison.OrdinalIgnoreCase));

diff --git a/PlatformTools/LocalModuleCatalog.cs b/PlatformTools/LocalModuleCatalog.cs
@@ -6,7 +6,7 @@
 
 namespace PlatformTools
 {
-    internal class LocalModuleCatalog
+    internal static class LocalModuleCatalog
     {
         private static LocalCatalog _catalog;
 

diff --git a/PlatformTools/ModuleInstallerFacade.cs b/PlatformTools/ModuleInstallerFacade.cs
@@ -7,7 +7,7 @@
 
 namespace PlatformTools
 {
-    internal class ModuleInstallerFacade
+    internal static class ModuleInstallerFacade
     {
         private static ModuleInstaller _moduleInstaller;
 

diff --git a/PlatformTools/PackageManager.cs b/PlatformTools/PackageManager.cs
@@ -3,7 +3,7 @@
 
 namespace PlatformTools
 {
-    internal class PackageManager
+    internal static class PackageManager
     {
         private static readonly string _defaultModuleManifest = "https://raw.githubusercontent.com/VirtoCommerce/vc-modules/master/modules_v3.json";
-Original file line number
+Diff line change
@@ Expand Up / @@ -201,6 +201,7 @@ private bool NeedToInstallPlatform(string version) @@
                         if (externalModule == null)
                         {
                             ControlFlow.Fail($"No module {module.Id} found");
+                            return;
                         }
                         if (alreadyInstalledModules.Any(installedModule => installedModule.ModuleName == module.Id && installedModule.Version.ToString() == module.Version))
@@ Expand Down @@