VCI-772: Fix codesmells

VirtoCommerce · Feb 21, 2024 · a5a50f7 · a5a50f7
1 parent e190dd9
commit a5a50f7
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 5 deletions.
diff --git a/src/VirtoCommerce.Build/Build.cs b/src/VirtoCommerce.Build/Build.cs
@@ -841,7 +841,7 @@ private static void CreateNukeDirectory()
 
         var nukeFiles = Directory.GetFiles(currentDirectory, ".nuke");
 
-        if (!nukeFiles.Any() && !Directory.Exists(Path.Join(currentDirectory, ".nuke")))
+        if (nukeFiles.Length == 0 && !Directory.Exists(Path.Join(currentDirectory, ".nuke")))
         {
             Console.WriteLine("No .nuke file found!");
             var solutions = Directory.GetFiles(currentDirectory, "*.sln");
@@ -857,7 +857,7 @@ private static void CreateNukeDirectory()
                 CreateDotNuke(currentDirectory);
             }
         }
-        else if (nukeFiles.Any())
+        else if (nukeFiles.Length > 0)
         {
             var nukeFile = nukeFiles[0];
             ConvertDotNukeFile(nukeFile);
@@ -1202,7 +1202,7 @@ private static void CleanSolution(string[] searchPattern, AbsolutePath[] ignoreP
     {
         if (SourceDirectory.DirectoryExists())
         {
-            if (ignorePaths?.Any() == true)
+            if (ignorePaths?.Length > 0)
             {
                 SourceDirectory
                     .GlobDirectories(searchPattern)

diff --git a/src/VirtoCommerce.Build/Cloud/Build.SaaS.cs b/src/VirtoCommerce.Build/Cloud/Build.SaaS.cs
@@ -378,7 +378,7 @@ private void SaveCloudToken(string token)
     public Target CloudUp => _ => _
         .DependsOn(CloudInit, CloudDeploy);
 
-    private static ISaaSDeploymentApi CreateVirtocloudClient(string url, string token)
+    private static SaaSDeploymentApi CreateVirtocloudClient(string url, string token)
     {
         var config = new VirtoCloud.Client.Client.Configuration();
         config.BasePath = url;

diff --git a/src/VirtoCommerce.Build/Extensions/PathExtension.cs b/src/VirtoCommerce.Build/Extensions/PathExtension.cs
@@ -12,7 +12,10 @@ public static class PathExtension
     {
         public static AbsolutePath ToAbsolutePath(this string path)
         {
-            if(path == null) return null;
+            if(path == null)
+            {
+                return null;
+            }
 
             return AbsolutePath.Create(Path.GetFullPath(path));
         }