Skip to content

Commit

Permalink
VCI-772: Minor fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
krankenbro committed Feb 22, 2024
1 parent b753f5f commit e52b12d
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions src/VirtoCommerce.Build/PlatformTools/Build.MatchVerisons.cs
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
using Nuke.Common;
using Nuke.Common.ProjectModel;
using Nuke.Common.Utilities;
using Nuke.Common.Utilities.Collections;
using PlatformTools;
using VirtoCommerce.Platform.Core.Common;
using VirtoCommerce.Platform.Core.Modularity;
Expand Down Expand Up @@ -40,7 +39,7 @@ internal partial class Build
var missedDependenciesErrors = ValidateForMissedDependencies(allPackages);
errors.AddRange(missedDependenciesErrors);

if (!errors.IsEmpty())
if (errors.Count > 0)
{
Assert.Fail(errors.Join(Environment.NewLine));
}
Expand Down Expand Up @@ -81,12 +80,13 @@ private static IEnumerable<PackageItem> GetProjectPackages(Project project)
/// <summary>
/// Check match between manifest platform version and platform packages
/// </summary>
private IEnumerable<string> ValdatePlatformVersion(IEnumerable<PackageItem> packages)
private List<string> ValdatePlatformVersion(IEnumerable<PackageItem> packages)
{
return packages
.Where(package => package.IsPlatformPackage && SemanticVersion.Parse(package.Version) != SemanticVersion.Parse(ModuleManifest.PlatformVersion))
.Select(x =>
$"Mismatched platform dependency version found. Platform version: {ModuleManifest.PlatformVersion}, Platform package name: {x.Name}, platform package version: {x.Version}, project name: {x.ProjectName}");
$"Mismatched platform dependency version found. Platform version: {ModuleManifest.PlatformVersion}, Platform package name: {x.Name}, platform package version: {x.Version}, project name: {x.ProjectName}")
.ToList();
}

/// <summary>
Expand Down

0 comments on commit e52b12d

Please sign in to comment.