Skip to content

Commit

Permalink
VCI-864: Replace deprecated sonar.login parameter (#134)
Browse files Browse the repository at this point in the history
  • Loading branch information
krankenbro authored Apr 10, 2024
1 parent 9682428 commit f317320
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
5 changes: 2 additions & 3 deletions src/VirtoCommerce.Build/Build.cs
Original file line number Diff line number Diff line change
Expand Up @@ -732,12 +732,11 @@ private static void WebPackBuildMethod(Project webProject)
Log.Information($"BRANCH_NAME = {branchName}");

SonarScannerTasks.SonarScannerBegin(c => c
.SetFramework("net5.0")
.SetName(RepoName)
.SetProjectKey($"{RepoOrg}_{RepoName}")
.SetVersion(ReleaseVersion)
.SetServer(SonarUrl)
.SetLogin(SonarAuthToken)
.SetToken(SonarAuthToken)
.SetOrganization(SonarOrg)
.SetGenericCoveragePaths(CoverageReportPath)
.When(PullRequest, cc => cc
Expand Down Expand Up @@ -799,7 +798,7 @@ private static void WebPackBuildMethod(Project webProject)

SonarScannerTasks.SonarScannerEnd(c => c
.SetFramework(framework)
.SetLogin(SonarAuthToken));
.SetToken(SonarAuthToken));
});

public Target StartAnalyzer => _ => _
Expand Down
2 changes: 1 addition & 1 deletion src/VirtoCommerce.Build/VirtoCommerce.Build.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
<PackageReference Include="System.Data.SqlClient" Version="4.8.2" />
<PackageReference Include="Nuke.Common" Version="8.0.0" />
<PackageReference Include="Microsoft.TeamFoundationServer.Client" Version="16.170.0" />
<PackageReference Include="dotnet-sonarscanner" Version="5.8.0">
<PackageReference Include="dotnet-sonarscanner" Version="6.2.0">
<ExcludeAssets>all</ExcludeAssets>
</PackageReference>
<PackageReference Include="Microsoft.Build.Locator" Version="1.7.1" />
Expand Down

0 comments on commit f317320

Please sign in to comment.