fix: cart refreshing issues #1507
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivan-kalachikov
requested review from
Andrew-Orlov,
goldenmaya and
NaMax66
and removed request for
a team
NaMax66
reviewed
Dec 19, 2024
| @@ -101,6 +101,6 @@ function onValidationUpdate(validation: { isValid: true } | { isValid: false; er | |||
| } | |||
|
|
|||
| watch(countInCart, (newCount) => { | |||
| quantity.value = newCount || 1; | |||
| quantity.value = newCount || product.value.minQuantity || 1; | |||
There was a problem hiding this comment.
it was a not related to the task bug, which I spotted during testing my changes, decided to fix it at once in that PR
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
References
Jira-link:
https://virtocommerce.atlassian.net/browse/VCST-2350
Artifact URL:
https://vc3prerelease.blob.core.windows.net/packages/vc-theme-b2b-vue-2.12.0-pr-1507-fc42-fc42b6f9.zip