Skip to content
Module CI

fix review comment #450

Sign in to view logs

fix review comment

fix review comment #450

Triggered via push December 15, 2023 10:22
@OlegoOOlegoO
pushed 98449c5
dev
Status Success
Total duration 20m 33s
Artifacts 1

module-ci.yml

on: push
ci
3m 33s
ci
module-katalon-tests  /  e2e-tests
16m 46s
module-katalon-tests / e2e-tests
Matrix: deploy-cloud / Deploy
Fit to window
Zoom out
Zoom in

Annotations

3 errors and 13 warnings
ci
Cloning into '/home/runner/work/vc-module-order/vc-module-order/artifacts/vc-modules'...
ci
ci
0cdba283..783c6087 HEAD -> master
ci
/home/runner/work/vc-module-order/vc-module-order/src/VirtoCommerce.OrdersModule.Core/Model/CustomerOrderResponseGroup.cs(6,17): warning S2342: Rename this enumeration to match the regular expression: '^([A-Z]{1,3}[a-z0-9]+)*([A-Z]{2})?s$'. (https://rules.sonarsource.com/csharp/RSPEC-2342) [/home/runner/work/vc-module-order/vc-module-order/src/VirtoCommerce.OrdersModule.Core/VirtoCommerce.OrdersModule.Core.csproj]
ci
/home/runner/work/vc-module-order/vc-module-order/src/VirtoCommerce.OrdersModule.Core/Model/CustomerOrderResponseGroup.cs(8,9): warning S2346: Rename 'Default' to 'None'. (https://rules.sonarsource.com/csharp/RSPEC-2346) [/home/runner/work/vc-module-order/vc-module-order/src/VirtoCommerce.OrdersModule.Core/VirtoCommerce.OrdersModule.Core.csproj]
ci
/home/runner/work/vc-module-order/vc-module-order/src/VirtoCommerce.OrdersModule.Core/ModuleConstants.cs(10,18): warning S1118: Add a 'protected' constructor or the 'static' keyword to the class declaration. (https://rules.sonarsource.com/csharp/RSPEC-1118) [/home/runner/work/vc-module-order/vc-module-order/src/VirtoCommerce.OrdersModule.Core/VirtoCommerce.OrdersModule.Core.csproj]
ci
/home/runner/work/vc-module-order/vc-module-order/src/VirtoCommerce.OrdersModule.Core/ModuleConstants.cs(60,49): warning S1104: Make this field 'private' and encapsulate it in a 'public' property. (https://rules.sonarsource.com/csharp/RSPEC-1104) [/home/runner/work/vc-module-order/vc-module-order/src/VirtoCommerce.OrdersModule.Core/VirtoCommerce.OrdersModule.Core.csproj]
ci
/home/runner/work/vc-module-order/vc-module-order/src/VirtoCommerce.OrdersModule.Core/ModuleConstants.cs(60,49): warning S2223: Change the visibility of 'OrderStatus' or make it 'const' or 'readonly'. (https://rules.sonarsource.com/csharp/RSPEC-2223) [/home/runner/work/vc-module-order/vc-module-order/src/VirtoCommerce.OrdersModule.Core/VirtoCommerce.OrdersModule.Core.csproj]
ci
/home/runner/work/vc-module-order/vc-module-order/src/VirtoCommerce.OrdersModule.Core/ModuleConstants.cs(113,49): warning S1104: Make this field 'private' and encapsulate it in a 'public' property. (https://rules.sonarsource.com/csharp/RSPEC-1104) [/home/runner/work/vc-module-order/vc-module-order/src/VirtoCommerce.OrdersModule.Core/VirtoCommerce.OrdersModule.Core.csproj]
ci
/home/runner/work/vc-module-order/vc-module-order/src/VirtoCommerce.OrdersModule.Core/ModuleConstants.cs(124,49): warning S1104: Make this field 'private' and encapsulate it in a 'public' property. (https://rules.sonarsource.com/csharp/RSPEC-1104) [/home/runner/work/vc-module-order/vc-module-order/src/VirtoCommerce.OrdersModule.Core/VirtoCommerce.OrdersModule.Core.csproj]
ci
/home/runner/work/vc-module-order/vc-module-order/src/VirtoCommerce.OrdersModule.Core/ModuleConstants.cs(113,49): warning S2223: Change the visibility of 'ShipmentStatus' or make it 'const' or 'readonly'. (https://rules.sonarsource.com/csharp/RSPEC-2223) [/home/runner/work/vc-module-order/vc-module-order/src/VirtoCommerce.OrdersModule.Core/VirtoCommerce.OrdersModule.Core.csproj]
ci
/home/runner/work/vc-module-order/vc-module-order/src/VirtoCommerce.OrdersModule.Core/ModuleConstants.cs(124,49): warning S2223: Change the visibility of 'PaymentInStatus' or make it 'const' or 'readonly'. (https://rules.sonarsource.com/csharp/RSPEC-2223) [/home/runner/work/vc-module-order/vc-module-order/src/VirtoCommerce.OrdersModule.Core/VirtoCommerce.OrdersModule.Core.csproj]
ci
/home/runner/work/vc-module-order/vc-module-order/src/VirtoCommerce.OrdersModule.Core/ModuleConstants.cs(146,49): warning S1104: Make this field 'private' and encapsulate it in a 'public' property. (https://rules.sonarsource.com/csharp/RSPEC-1104) [/home/runner/work/vc-module-order/vc-module-order/src/VirtoCommerce.OrdersModule.Core/VirtoCommerce.OrdersModule.Core.csproj]
ci
/usr/share/dotnet/sdk/8.0.100/Sdks/NuGet.Build.Tasks.Pack/build/NuGet.Build.Tasks.Pack.targets(203,6): warning : This project cannot be packaged because packaging has been disabled. Add <IsPackable>true</IsPackable> to the project file to enable producing a package from this project. [/home/runner/work/vc-module-order/vc-module-order/samples/VirtoCommerce.OrdersModule2.Web/VirtoCommerce.OrdersModule2.Web.csproj]
ci
/usr/share/dotnet/sdk/8.0.100/Sdks/NuGet.Build.Tasks.Pack/build/NuGet.Build.Tasks.Pack.targets(203,6): warning : This project cannot be packaged because packaging has been disabled. Add <IsPackable>true</IsPackable> to the project file to enable producing a package from this project. [/home/runner/work/vc-module-order/vc-module-order/src/VirtoCommerce.OrdersModule.Web/VirtoCommerce.OrdersModule.Web.csproj]
module-katalon-tests / e2e-tests
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/upload-artifact@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

Artifacts

Produced during runtime
Name Size
reports Expired
83.2 MB