Skip to content

VCST-1564: Adds FindExistingLineItemBeforeAdd methods (#8) #27

VCST-1564: Adds FindExistingLineItemBeforeAdd methods (#8)

VCST-1564: Adds FindExistingLineItemBeforeAdd methods (#8) #27

Triggered via push August 9, 2024 13:39
Status Failure
Total duration 14m 59s
Artifacts 1

module-ci.yml

on: push
module-katalon-tests  /  e2e-tests
12m 24s
module-katalon-tests / e2e-tests
Matrix: deploy-cloud / Deploy
Fit to window
Zoom out
Zoom in

Annotations

4 errors and 10 warnings
ci
Cloning into '/home/runner/work/vc-module-x-cart/vc-module-x-cart/artifacts/vc-modules'...
ci
bc44362a..e568f442 HEAD -> master
module-katalon-tests / e2e-tests
Katalon Studio execution failed with status 1.
ci
/home/runner/work/vc-module-x-cart/vc-module-x-cart/src/VirtoCommerce.XCart.Core/Models/CartProduct.cs(23,15): warning S1135: Complete the task associated to this 'TODO' comment. (https://rules.sonarsource.com/csharp/RSPEC-1135) [/home/runner/work/vc-module-x-cart/vc-module-x-cart/src/VirtoCommerce.XCart.Core/VirtoCommerce.XCart.Core.csproj]
ci
/home/runner/work/vc-module-x-cart/vc-module-x-cart/src/VirtoCommerce.XCart.Core/Models/CartAggregateResponseGroup.cs(6,17): warning S2342: Rename this enumeration to match the regular expression: '^([A-Z]{1,3}[a-z0-9]+)*([A-Z]{2})?s$'. (https://rules.sonarsource.com/csharp/RSPEC-2342) [/home/runner/work/vc-module-x-cart/vc-module-x-cart/src/VirtoCommerce.XCart.Core/VirtoCommerce.XCart.Core.csproj]
ci
/home/runner/work/vc-module-x-cart/vc-module-x-cart/src/VirtoCommerce.XCart.Core/Models/CartValidationError.cs(33,18): warning S2365: Refactor 'ErrorParameters' into a method, properties should not copy collections. (https://rules.sonarsource.com/csharp/RSPEC-2365) [/home/runner/work/vc-module-x-cart/vc-module-x-cart/src/VirtoCommerce.XCart.Core/VirtoCommerce.XCart.Core.csproj]
ci
/home/runner/work/vc-module-x-cart/vc-module-x-cart/src/VirtoCommerce.XCart.Core/CartAggregate.cs(51,29): warning S107: Constructor has 8 parameters, which is greater than the 7 authorized. (https://rules.sonarsource.com/csharp/RSPEC-107) [/home/runner/work/vc-module-x-cart/vc-module-x-cart/src/VirtoCommerce.XCart.Core/VirtoCommerce.XCart.Core.csproj]
ci
/home/runner/work/vc-module-x-cart/vc-module-x-cart/src/VirtoCommerce.XCart.Core/CartAggregate.cs(158,50): warning S4457: Split this method into two, one handling parameters check and the other handling the asynchronous code. (https://rules.sonarsource.com/csharp/RSPEC-4457) [/home/runner/work/vc-module-x-cart/vc-module-x-cart/src/VirtoCommerce.XCart.Core/VirtoCommerce.XCart.Core.csproj]
ci
/home/runner/work/vc-module-x-cart/vc-module-x-cart/src/VirtoCommerce.XCart.Core/Validators/ItemQtyAdjustmentValidator.cs(10,16): warning S3776: Refactor this constructor to reduce its Cognitive Complexity from 16 to the 15 allowed. (https://rules.sonarsource.com/csharp/RSPEC-3776) [/home/runner/work/vc-module-x-cart/vc-module-x-cart/src/VirtoCommerce.XCart.Core/VirtoCommerce.XCart.Core.csproj]
ci
/home/runner/work/vc-module-x-cart/vc-module-x-cart/src/VirtoCommerce.XCart.Core/Extensions/TaxExtensions.cs(33,93): warning S109: Assign this magic number '4' to a well-named variable or constant, and use that instead. (https://rules.sonarsource.com/csharp/RSPEC-109) [/home/runner/work/vc-module-x-cart/vc-module-x-cart/src/VirtoCommerce.XCart.Core/VirtoCommerce.XCart.Core.csproj]
ci
/home/runner/work/vc-module-x-cart/vc-module-x-cart/src/VirtoCommerce.XCart.Core/Validators/ItemQtyAdjustmentValidator.cs(10,16): warning S1541: The Cyclomatic Complexity of this constructor is 13 which is greater than 10 authorized. (https://rules.sonarsource.com/csharp/RSPEC-1541) [/home/runner/work/vc-module-x-cart/vc-module-x-cart/src/VirtoCommerce.XCart.Core/VirtoCommerce.XCart.Core.csproj]
ci
/home/runner/work/vc-module-x-cart/vc-module-x-cart/src/VirtoCommerce.XCart.Core/Extensions/TaxExtensions.cs(89,89): warning S109: Assign this magic number '4' to a well-named variable or constant, and use that instead. (https://rules.sonarsource.com/csharp/RSPEC-109) [/home/runner/work/vc-module-x-cart/vc-module-x-cart/src/VirtoCommerce.XCart.Core/VirtoCommerce.XCart.Core.csproj]
ci
/home/runner/work/vc-module-x-cart/vc-module-x-cart/src/VirtoCommerce.XCart.Core/Extensions/TaxExtensions.cs(58,91): warning S109: Assign this magic number '4' to a well-named variable or constant, and use that instead. (https://rules.sonarsource.com/csharp/RSPEC-109) [/home/runner/work/vc-module-x-cart/vc-module-x-cart/src/VirtoCommerce.XCart.Core/VirtoCommerce.XCart.Core.csproj]

Artifacts

Produced during runtime
Name Size
reports Expired
7.92 MB