Calculate cart totals before promotion evaluation #91
tatarincevmodule-ci.yml
on: pull_request
ci
1m 48s
module-katalon-tests
/
e2e-tests
Matrix: deploy-cloud / Deploy
Waiting for pending jobs
Annotations
3 errors and 11 warnings
|
ci
[xUnit.net 00:00:12.23] VirtoCommerce.XCart.Tests.Aggregates.CartAggregateTests.RecalculateAsync_HasPromoRewards_CalculateTotalsCalled [FAIL]
|
|
ci
Target "Test" has thrown an exception
|
|
ci
Process completed with exit code 255.
|
|
ci
/home/runner/work/vc-module-x-cart/vc-module-x-cart/src/VirtoCommerce.XCart.Core/CartAggregate.cs(51,29): warning S107: Constructor has 8 parameters, which is greater than the 7 authorized. (https://rules.sonarsource.com/csharp/RSPEC-107) [/home/runner/work/vc-module-x-cart/vc-module-x-cart/src/VirtoCommerce.XCart.Core/VirtoCommerce.XCart.Core.csproj]
|
|
ci
/home/runner/work/vc-module-x-cart/vc-module-x-cart/src/VirtoCommerce.XCart.Core/CartAggregate.cs(170,50): warning S4457: Split this method into two, one handling parameters check and the other handling the asynchronous code. (https://rules.sonarsource.com/csharp/RSPEC-4457) [/home/runner/work/vc-module-x-cart/vc-module-x-cart/src/VirtoCommerce.XCart.Core/VirtoCommerce.XCart.Core.csproj]
|
|
ci
/home/runner/work/vc-module-x-cart/vc-module-x-cart/src/VirtoCommerce.XCart.Core/CartAggregate.cs(268,29): warning S1067: Reduce the number of conditional operators (4) used in the expression (maximum allowed 3). (https://rules.sonarsource.com/csharp/RSPEC-1067) [/home/runner/work/vc-module-x-cart/vc-module-x-cart/src/VirtoCommerce.XCart.Core/VirtoCommerce.XCart.Core.csproj]
|
|
ci
/home/runner/work/vc-module-x-cart/vc-module-x-cart/src/VirtoCommerce.XCart.Core/CartAggregate.cs(250,50): warning S1541: The Cyclomatic Complexity of this method is 20 which is greater than 10 authorized. (https://rules.sonarsource.com/csharp/RSPEC-1541) [/home/runner/work/vc-module-x-cart/vc-module-x-cart/src/VirtoCommerce.XCart.Core/VirtoCommerce.XCart.Core.csproj]
|
|
ci
/home/runner/work/vc-module-x-cart/vc-module-x-cart/src/VirtoCommerce.XCart.Core/CartAggregate.cs(730,61): warning S4457: Split this method into two, one handling parameters check and the other handling the asynchronous code. (https://rules.sonarsource.com/csharp/RSPEC-4457) [/home/runner/work/vc-module-x-cart/vc-module-x-cart/src/VirtoCommerce.XCart.Core/VirtoCommerce.XCart.Core.csproj]
|
|
ci
/home/runner/work/vc-module-x-cart/vc-module-x-cart/src/VirtoCommerce.XCart.Core/CartAggregate.cs(51,29): warning S107: Constructor has 8 parameters, which is greater than the 7 authorized. (https://rules.sonarsource.com/csharp/RSPEC-107) [/home/runner/work/vc-module-x-cart/vc-module-x-cart/src/VirtoCommerce.XCart.Core/VirtoCommerce.XCart.Core.csproj]
|
|
ci
/home/runner/work/vc-module-x-cart/vc-module-x-cart/src/VirtoCommerce.XCart.Core/CartAggregate.cs(170,50): warning S4457: Split this method into two, one handling parameters check and the other handling the asynchronous code. (https://rules.sonarsource.com/csharp/RSPEC-4457) [/home/runner/work/vc-module-x-cart/vc-module-x-cart/src/VirtoCommerce.XCart.Core/VirtoCommerce.XCart.Core.csproj]
|
|
ci
/home/runner/work/vc-module-x-cart/vc-module-x-cart/src/VirtoCommerce.XCart.Core/CartAggregate.cs(268,29): warning S1067: Reduce the number of conditional operators (4) used in the expression (maximum allowed 3). (https://rules.sonarsource.com/csharp/RSPEC-1067) [/home/runner/work/vc-module-x-cart/vc-module-x-cart/src/VirtoCommerce.XCart.Core/VirtoCommerce.XCart.Core.csproj]
|
|
ci
/home/runner/work/vc-module-x-cart/vc-module-x-cart/src/VirtoCommerce.XCart.Core/CartAggregate.cs(250,50): warning S1541: The Cyclomatic Complexity of this method is 20 which is greater than 10 authorized. (https://rules.sonarsource.com/csharp/RSPEC-1541) [/home/runner/work/vc-module-x-cart/vc-module-x-cart/src/VirtoCommerce.XCart.Core/VirtoCommerce.XCart.Core.csproj]
|
|
ci
/home/runner/work/vc-module-x-cart/vc-module-x-cart/src/VirtoCommerce.XCart.Core/CartAggregate.cs(730,61): warning S4457: Split this method into two, one handling parameters check and the other handling the asynchronous code. (https://rules.sonarsource.com/csharp/RSPEC-4457) [/home/runner/work/vc-module-x-cart/vc-module-x-cart/src/VirtoCommerce.XCart.Core/VirtoCommerce.XCart.Core.csproj]
|
|
ci
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|