Skip to content

Commit

Permalink
fix: Improves setting's title (#2864)
Browse files Browse the repository at this point in the history
  • Loading branch information
OlegoO committed Dec 2, 2024
1 parent 7f35161 commit 8f5ea00
Show file tree
Hide file tree
Showing 5 changed files with 19 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ angular.module('platformWebApp')
id: 'settingsSection',
data: selectedSettings,
headIcon: node.icon || '',
title: node.name || 'platform.blades.settings-detail.title',
title: node.groupName || 'platform.blades.settings-detail.title',
disableOpenAnimation: disableOpenAnimation,
controller: node.controller || 'platformWebApp.settingsDetailController',
template: node.template || '$(Platform)/Scripts/app/settings/blades/settings-detail.tpl.html',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,14 @@ angular.module('platformWebApp')
function initializeBlade() {
blade.isLoading = true;

// Resolve setting group name
var setting = Array.isArray(blade.data) && blade.data.length > 0 ? blade.data[0] : null;

if (setting && setting.groupName) {
var paths = setting.groupName.split('|');
blade.groupName = paths.pop();
}

settingsApi.getUiCustomizationSetting(function (uiCustomizationSetting) {
blade.isLoading = false;
blade.uiCustomizationSetting = uiCustomizationSetting;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<div class="blade-static __bottom" ng-if="blade.isSavingToParentObject" ng-include="'$(Platform)/Scripts/common/templates/ok-cancel2.tpl.html'"></div>
<div class="themeSettingsBlade themeSettingsBlade__blade-content">

<legend class="themeSettingsBlade themeSettingsBlade__title">{{ blade.title }}</legend>
<legend class="themeSettingsBlade themeSettingsBlade__title">{{ blade.groupName }}</legend>

<div class="themeSettingsBlade themeSettingsBlade__blade-inner">
<div class="themeSettingsBlade themeSettingsBlade__inner-block">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,14 @@ angular.module('platformWebApp')
function initializeBlade() {
blade.isLoading = true;

// Resolve setting group name
var setting = Array.isArray(blade.data) && blade.data.length > 0 ? blade.data[0] : null;

if (setting && setting.groupName) {
var paths = setting.groupName.split('|');
blade.groupName = paths.pop();
}

settingsApi.getUiCustomizationSetting(function (uiCustomizationSetting) {
blade.isLoading = false;
blade.uiCustomizationSetting = uiCustomizationSetting;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<div class="blade-static __bottom" ng-if="blade.isSavingToParentObject" ng-include="'$(Platform)/Scripts/common/templates/ok-cancel2.tpl.html'"></div>
<div class="themeSettingsBlade themeSettingsBlade__blade-content">

<legend class="themeSettingsBlade themeSettingsBlade__title">{{ blade.title }}</legend>
<legend class="themeSettingsBlade themeSettingsBlade__title">{{ blade.groupName }}</legend>

<div class="themeSettingsBlade themeSettingsBlade__blade-inner">
<div class="themeSettingsBlade themeSettingsBlade__inner-block">
Expand Down

0 comments on commit 8f5ea00

Please sign in to comment.