Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: calc pH on succes answer only #10

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

fialkovod
Copy link

No description provided.

@kkirpichnikov
Copy link
Contributor

kkirpichnikov commented Jun 19, 2023

@fialkovod Не совсем понятен смысл изменений, если не трудно объясни, пожалуйста.

@fialkovod
Copy link
Author

Расчет pH, как и ЕС в текущей реализации, должен вестись только при получении корректного ответа от сервера. Без фикса расчет ведется всегда, даже при невалидном json. Фикс исправляет этот баг.

@kkirpichnikov kkirpichnikov requested a review from siv237 August 17, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants