Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(TeacherProjectService): Move branch authoring code #1221

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

hirokiterashima
Copy link
Member

Changes

  • In TeacherProjectService, move these functions to NodeAdvancedBranchAuthoringComponent, where they're actually being called
    • setTransitionLogicField()
    • setTransition()
    • addBranchPathTakenConstraints()
  • Remove TeacherProjectService.isNodeIdUsed() since it's unused
  • Use nullish coalescence (??) in ProjectService.instantiateDefaults()
  • Add private keyword and function return types in surrounding code

Test

  • Node branch authoring works as before (e.g. creates correct transitions and constraints)
  • Unit loads as before in VLE, CM, AT (to test ProjectService.instantiateDefaults())

Closes #1220

@hirokiterashima hirokiterashima self-assigned this May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

refactor(TeacherProjectService): Move branch authoring code
1 participant