wasm2c: minor code cleanup for OS checks for segue #2504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithw
approved these changes
Nov 11, 2024
There was a problem hiding this comment.
Maybe this can link to https://www.kernel.org/doc/html/latest/arch/x86/x86_64/fsgs.html#fsgsbase-instructions-enablement (even just in the commit message) to show where this is documented?
Fair warning, my view is that we should probably work towards some sort of system of hooks (preprocessor macros that wasm2c can insert with the right command-line argument) that allows seque to live in its own file or directory that you can edit without needing a full review on each change.
shravanrn
force-pushed
the
segue-minor-cleanup
branch
from
37f1048
to
a4cd78b
Compare
Define the fsgabase capability lookup to HWCAP2_FSGSBASE as per https://www.kernel.org/doc/html/latest/arch/x86/x86_64/fsgs.html#fsgsbase-instructions-enablement
shravanrn
force-pushed
the
segue-minor-cleanup
branch
from
a4cd78b
to
e968998
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define the fsgabase capability lookup to
HWCAP2_FSGSBASE as per
https://www.kernel.org/doc/html/latest/arch/x86/x86_64/fsgs.html#fsgsbase-instructions-enablement