Fix missing parameter in setShareLimits #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d issues with old versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, let me preface by saying this is the first time I touch C#.
qBittorrent 4.6.0 merged qbittorrent/qBittorrent#19294 adding a new required parameter to setShareLimit.
This pull request adds support for that only on versions 4.6.0 and up, to avoid issues for people still running older qBittorrent versions.
https://github.com/imatimba/QbtManager/blob/6beddfcd5aab5fedd6c0002d5cfbbd37ed8b912b/QbtManager/Program.cs#L200-L211 ⇽ I'm not sure if this logic is correct, but I couldn't find any errors testing different combinations of setShareLimit parameters.
Also took the liberty to change the log string of SetMaxLimits to use string interpolation, as the concatenations + ternary operator (added because of the version check) were becoming quite unreadable.