Move Link method off Ring metatable #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's a bug in the upgrade logic where existing rings created by older versions of the library never have their metatables upgraded. As such, a load of a version older than v25 followed by v25 or newer will result in a call to a nil 'Link' method on rings. Rather than think through the ramifications of just setmetatable-ing rings again unilaterally on upgrade (though that is probably a perfectly sane idea and should work), for now let's just make the new Link method a local function instead as that's the safer option.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a bug in the upgrade logic where existing rings created by older versions of the library never have their metatables upgraded. As such, a load of a version older than v25 followed by v25 or newer will result in a call to a nil 'Link' method on rings.
Rather than think through the ramifications of just setmetatable-ing rings again unilaterally on upgrade (though that is probably a perfectly sane idea and should work), for now let's just make the new Link method a local function instead as that's the safer option.