ChatThrottleLib: Upgrade Ring metatables on library upgrades #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Meorawr
changed the title
This is hopefully a non-risky and better change going forward, but don't want to rock the boat immediately after fixing one upgrade issue. As changing the implementation of any Ring method in a current version means it has no effect on rings created in older versions, it makes sense to apply the new metatable to avoid this trap in the future. This appears to work fine from an upgrade of version 24 to 28 (which adds the Link method to Ring).
Meorawr
force-pushed
the
patch/please-mind-the-metatable-between-the-train-and-the-upgraded-library
branch
from
6c0c0fa to
bb5a22f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is hopefully a non-risky and better change going forward, but don't want to rock the boat immediately after fixing one upgrade issue so this can just sit and fester cobwebs in a corner for a while.
As changing the implementation of any Ring method in a current version means it has no effect on rings created in older versions, it makes sense to apply the new metatable to avoid this trap in the future.
This appears to work fine from an upgrade of version 24 direct to 28 which adds the Link method to Ring, but it hasn't been too exhaustively tested - very possible I may have missed something.