Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent TreeGroup buttons being broken somehow #23

Merged
merged 4 commits into from
Dec 5, 2024

Conversation

Justw8
Copy link
Contributor

@Justw8 Justw8 commented Dec 3, 2024

There has been the issue of BW treegroup being shown after closing the menu, which is also visible in different ways - even though the frames are hidden correctly and are not shown in /fstack.

image

After just trying some things, I noticed that hiding the frames at the end of the logic resulted in more robust handling of the situation. That's why the code is as it is now.

I have also tried just hiding the frames in the for loop on line 468-470, that however resulted in the same issue.

Here are 2 clips with the change, and without the change:

Hiding before re-creating the tree:
https://streamable.com/grj7oe

Hiding after creating the tree:
https://streamable.com/3t4qpg

I've used this for some weeks, and not had issues after adding this and I don't see why we wouldn't add this atm.

@Nevcairiel
Copy link
Contributor

If i see this right, you could just simplify this a bunch by not keeping a flag, but rather using buttonnum to hide any remaining buttons

@Justw8
Copy link
Contributor Author

Justw8 commented Dec 4, 2024

If i see this right, you could just simplify this a bunch by not keeping a flag, but rather using buttonnum to hide any remaining buttons

Yep, done. Still results in me not having the invisible-visible frames.

@Nevcairiel Nevcairiel merged commit 0c3bea6 into WoWUIDev:master Dec 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants