Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flatpak-relevant files #1077

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Add flatpak-relevant files #1077

merged 1 commit into from
Apr 17, 2024

Conversation

smirnov
Copy link
Contributor

@smirnov smirnov commented Mar 20, 2024

As requested in issue #403 I've created a flatpak package and in the package creation discussion it was suggested that I at the very least suggest putting the logo in PNG format and a desktop file with the source of the application, so here it is.

If you think that this is not useful or can suggest a better/alternative approach, I'm happy to hear it.

@coelckers
Copy link
Member

You forgot "Shadow Warrior" in your list of keywords.

@madame-rachelle
Copy link
Collaborator

One thing I wonder is why this is needed for Raze but GZDoom doesn't have it and gets flatpaks published just fine. Though rather than dismissing this one, I'd prefer GZDoom to have a similar thing, instead.

@smirnov
Copy link
Contributor Author

smirnov commented Mar 21, 2024

It's not "needed" as in "it won't be published if it's not there", as of right now Raze is on flathub. But it is a recommendation from Flathub to have those files upstream (and metadata, specifically for flatpak, forgot that one). If upstream doesn't agree, then the files are left in the flathub repo.

Maintainer for GZDoom has mentioned that their suggestion was rejected, flathub/flathub#5022 (comment) but if you see value in it - I'm happy to create PR for GZDoom as well (from what I can see the dev team is pretty much the same)

@QmwJlHuSg9pa
Copy link

You forgot "Shadow Warrior" in your list of keywords.

Adding to this, in GNOME Software, "duke nukem" returns no results, let alone "duke nukem 3d". Only "duke" or "nukem" individually present Raze in the search results.

@smirnov
Copy link
Contributor Author

smirnov commented Mar 22, 2024

@QmwJlHuSg9pa thanks for the heads up. I see the 3d tag is missing, I'll fix that, but the "duke nukem" definitely returns results. Maybe a cache issue?
image

@madame-rachelle madame-rachelle merged commit 68ccf7a into ZDoom:master Apr 17, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants