Is the System.Threading.Tasks.Extensions PackageReference needed?

[Numpsy]

Just a thought whilst looking at some things - I don't think the System.Threading.Tasks.Extensions nuget package should be needed as it should be inbox in all the currently targeted TFMs?

On a related note, I'm unclear if the z440.atl.core NuGet package should have a dependency on the Zomp.SyncMethodGenerator NuGet package or if it should be a development only dependency, but I don't know exactly how that works so I 'm not sure.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f189d2e) 89.17% compared to head (374d7e1) 89.17%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #251   +/-   ##
=======================================
  Coverage   89.17%   89.17%           
=======================================
  Files          94       94           
  Lines       19170    19170           
  Branches     2820     2820           
=======================================
  Hits        17095    17095           
  Misses       1460     1460           
  Partials      615      615           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Zeugma440]

Thanks for pointing that out!

Regarding Zomp.SyncMethodGenerator, it is indeed a build-time dependency. I've adjusted the project file accordingly.

[sonarcloud]

Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

[Zeugma440]

Available in today's v5.20

[Numpsy]

Regarding Zomp.SyncMethodGenerator, it is indeed a build-time dependency. I've adjusted the project file accordingly.

FYI, the System.Threading.Tasks.Extensions dependency is gone now, but the NuGet listing is still showing Zomp.SyncMethodGenerator as a dependant package:

[Zeugma440]

Since the change I made (4251d59), the dependency is flagged with exclude="Runtime,Build,Analyzers" in the generated nupkg file, which looks okay to me.

<dependency id="Zomp.SyncMethodGenerator" version="1.0.12" exclude="Runtime,Build,Analyzers" />

I have no idea how to remove it entirely from the published metadata. Do you?

[Numpsy]

I have no idea how to remove it entirely from the published metadata. Do you?

#256 maybe?