Skip to content

Commit

Permalink
Fix Typo issue #4 on github and update version
Browse files Browse the repository at this point in the history
  • Loading branch information
varunest committed Jun 16, 2016
1 parent 7a842f5 commit 57ecfb0
Show file tree
Hide file tree
Showing 9 changed files with 39 additions and 33 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ This filter can be used to put vignette effect on the image.

```java
Filter myFilter = new Filter();
myFilter.addSubFilter(new VignetteSubfilter(100));
myFilter.addSubFilter(new VignetteSubfilter(context, 100));
Bitmap outputImage = myFilter.process(inputImage);
```

Expand Down
4 changes: 2 additions & 2 deletions gradle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@
# http://www.gradle.org/docs/current/userguide/multi_project_builds.html#sec:decoupled_projects
# org.gradle.parallel=true
android.useDeprecatedNdk=true
VERSION_NAME=1.0.0
VERSION_CODE=2
VERSION_NAME=1.0.1
VERSION_CODE=3
GROUP=com.github.zomato

POM_DESCRIPTION=Android Library aims to provide fast, powerful and flexible image processing instrument for creating awesome effects on any image media.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@

import com.zomato.photofilters.geometry.Point;
import com.zomato.photofilters.imageprocessors.Filter;
import com.zomato.photofilters.imageprocessors.subfilters.BrightnessSubFilter;
import com.zomato.photofilters.imageprocessors.subfilters.ContrastSubFilter;
import com.zomato.photofilters.imageprocessors.subfilters.ToneCurveSubFilter;
import com.zomato.photofilters.imageprocessors.subfilters.BrightnessSubfilter;
import com.zomato.photofilters.imageprocessors.subfilters.ContrastSubfilter;
import com.zomato.photofilters.imageprocessors.subfilters.ToneCurveSubfilter;

/**
* @author Varun on 01/07/15.
Expand All @@ -26,7 +26,7 @@ public static Filter getStarLitFilter() {
rgbKnots[6] = new Point(207, 233);
rgbKnots[7] = new Point(255, 255);
Filter filter = new Filter();
filter.addSubFilter(new ToneCurveSubFilter(rgbKnots, null, null, null));
filter.addSubFilter(new ToneCurveSubfilter(rgbKnots, null, null, null));
return filter;
}

Expand All @@ -42,9 +42,9 @@ public static Filter getBlueMessFilter() {
redKnots[6] = new Point(225, 242);
redKnots[7] = new Point(255, 255);
Filter filter = new Filter();
filter.addSubFilter(new ToneCurveSubFilter(null, redKnots, null, null));
filter.addSubFilter(new BrightnessSubFilter(30));
filter.addSubFilter(new ContrastSubFilter(1f));
filter.addSubFilter(new ToneCurveSubfilter(null, redKnots, null, null));
filter.addSubFilter(new BrightnessSubfilter(30));
filter.addSubFilter(new ContrastSubfilter(1f));
return filter;
}

Expand Down Expand Up @@ -88,7 +88,7 @@ public static Filter getAweStruckVibeFilter() {
blueKnots[6] = new Point(255, 255);

Filter filter = new Filter();
filter.addSubFilter(new ToneCurveSubFilter(rgbKnots, redKnots, greenKnots, blueKnots));
filter.addSubFilter(new ToneCurveSubfilter(rgbKnots, redKnots, greenKnots, blueKnots));
return filter;
}

Expand All @@ -100,7 +100,7 @@ public static Filter getLimeStutterFilter() {
blueKnots[2] = new Point(255, 255);
// Check whether output is null or not.
Filter filter = new Filter();
filter.addSubFilter(new ToneCurveSubFilter(null, null, null, blueKnots));
filter.addSubFilter(new ToneCurveSubfilter(null, null, null, blueKnots));
return filter;
}

Expand Down Expand Up @@ -132,7 +132,7 @@ public static Filter getNightWhisperFilter() {
blueKnots[2] = new Point(255, 255);

Filter filter = new Filter();
filter.addSubFilter(new ToneCurveSubFilter(rgbKnots, redKnots, greenKnots, blueKnots));
filter.addSubFilter(new ToneCurveSubfilter(rgbKnots, redKnots, greenKnots, blueKnots));
return filter;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,12 @@

import android.graphics.Bitmap;

import com.zomato.photofilters.imageprocessors.subfilters.BrightnessSubfilter;
import com.zomato.photofilters.imageprocessors.subfilters.ColorOverlaySubfilter;
import com.zomato.photofilters.imageprocessors.subfilters.ContrastSubfilter;
import com.zomato.photofilters.imageprocessors.subfilters.ToneCurveSubfilter;
import com.zomato.photofilters.imageprocessors.subfilters.VignetteSubfilter;

import java.util.ArrayList;
import java.util.Iterator;
import java.util.List;
Expand All @@ -25,11 +31,11 @@ public Filter() {
* Adds a Subfilter to the Main Filter
*
* @param subFilter Subfilter like contrast, brightness, tone Curve etc. subfilter
* @see com.zomato.photofilters.imageprocessors.subfilters.BrightnessSubFilter
* @see com.zomato.photofilters.imageprocessors.subfilters.ColorOverlaySubFilter
* @see com.zomato.photofilters.imageprocessors.subfilters.ContrastSubFilter
* @see com.zomato.photofilters.imageprocessors.subfilters.ToneCurveSubFilter
* @see com.zomato.photofilters.imageprocessors.subfilters.VignetteSubFitler
* @see BrightnessSubfilter
* @see ColorOverlaySubfilter
* @see ContrastSubfilter
* @see ToneCurveSubfilter
* @see VignetteSubfilter
* @see com.zomato.photofilters.imageprocessors.subfilters.SaturationSubfilter
*/
public void addSubFilter(SubFilter subFilter) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
* @author varun
* subfilter used to tweak brightness of the Bitmap
*/
public class BrightnessSubFilter implements SubFilter {
public class BrightnessSubfilter implements SubFilter {
private static String tag = "";
// Value is in integer
private int brightness = 0;
Expand All @@ -19,7 +19,7 @@ public class BrightnessSubFilter implements SubFilter {
*
* @param brightness Integer brightness value {value 0 has no effect}
*/
public BrightnessSubFilter(int brightness) {
public BrightnessSubfilter(int brightness) {
this.brightness = brightness;
}

Expand All @@ -35,7 +35,7 @@ public String getTag() {

@Override
public void setTag(Object tag) {
BrightnessSubFilter.tag = (String) tag;
BrightnessSubfilter.tag = (String) tag;
}

public void setBrightness(int brightness) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
* @author varun
* Subfilter used to overlay bitmap with the color defined
*/
public class ColorOverlaySubFilter implements SubFilter {
public class ColorOverlaySubfilter implements SubFilter {
private static String tag = "";

// the color overlay depth is between 0-255
Expand All @@ -28,7 +28,7 @@ public class ColorOverlaySubFilter implements SubFilter {
* @param green Green value between 0-1
* @param blue Blue value between 0-1
*/
public ColorOverlaySubFilter(int depth, float red, float green, float blue) {
public ColorOverlaySubfilter(int depth, float red, float green, float blue) {
this.colorOverlayDepth = depth;
this.colorOverlayRed = red;
this.colorOverlayBlue = blue;
Expand All @@ -49,6 +49,6 @@ public String getTag() {

@Override
public void setTag(Object tag) {
ColorOverlaySubFilter.tag = (String) tag;
ColorOverlaySubfilter.tag = (String) tag;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
* @author varun
* Class to add Contrast Subfilter
*/
public class ContrastSubFilter implements SubFilter {
public class ContrastSubfilter implements SubFilter {

private static String tag = "";

Expand All @@ -21,7 +21,7 @@ public class ContrastSubFilter implements SubFilter {
*
* @param contrast The contrast value ranges in fraction, value 1 has no effect
*/
public ContrastSubFilter(float contrast) {
public ContrastSubfilter(float contrast) {
this.contrast = contrast;
}

Expand All @@ -37,7 +37,7 @@ public String getTag() {

@Override
public void setTag(Object tag) {
ContrastSubFilter.tag = (String) tag;
ContrastSubfilter.tag = (String) tag;
}

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
* @author varun
* Subfilter to tweak rgb channels of an image
*/
public class ToneCurveSubFilter implements SubFilter {
public class ToneCurveSubfilter implements SubFilter {
private static String tag = "";

// These are knots which contains the plot points
Expand All @@ -33,7 +33,7 @@ public class ToneCurveSubFilter implements SubFilter {
* @param greenKnots Knots in green Channel
* @param blueKnots Knots in Blue channel
*/
public ToneCurveSubFilter(Point[] rgbKnots, Point[] redKnots, Point[] greenKnots, Point[] blueKnots) {
public ToneCurveSubfilter(Point[] rgbKnots, Point[] redKnots, Point[] greenKnots, Point[] blueKnots) {
Point[] straightKnots = new Point[2];
straightKnots[0] = new Point(0, 0);
straightKnots[1] = new Point(255, 255);
Expand Down Expand Up @@ -108,6 +108,6 @@ public String getTag() {

@Override
public void setTag(Object tag) {
ToneCurveSubFilter.tag = (String) tag;
ToneCurveSubfilter.tag = (String) tag;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
* @author varun
* Subfilter to add Vignette effect on an image
*/
public class VignetteSubFitler implements SubFilter {
public class VignetteSubfilter implements SubFilter {

private static String tag = "";
private Context context;
Expand All @@ -26,7 +26,7 @@ public class VignetteSubFitler implements SubFilter {
*
* @param alpha value of alpha ranges from 0-255 (Intensity of Vignette effect)
*/
public VignetteSubFitler(Context context, int alpha) {
public VignetteSubfilter(Context context, int alpha) {
this.context = context;
this.alpha = alpha;
}
Expand All @@ -53,7 +53,7 @@ public Object getTag() {

@Override
public void setTag(Object tag) {
VignetteSubFitler.tag = (String) tag;
VignetteSubfilter.tag = (String) tag;
}

/**
Expand Down

0 comments on commit 57ecfb0

Please sign in to comment.