Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] Add hfModelFile to preset models for alignment with HF-sourced models & shortens the preset model lists #145

Merged
merged 7 commits into from
Dec 23, 2024

Conversation

a-ghorbani
Copy link
Owner

@a-ghorbani a-ghorbani commented Dec 21, 2024

Description

This PR adds the hfModelFile attribute to preset models, aligning them more closely with Hugging Face-sourced models. This enables users to share benchmark results.
This might break or have unpredictable behavior if users already download any of the models.

This also adds skills to the model lists.

Partially Fixes #144
Fixes #136

Platform Affected

  • iOS
  • Android

Checklist

  • Necessary comments have been made.
  • I have tested this change on:
    • iOS Simulator/Device
    • Android Emulator/Device
  • Unit tests and integration tests pass locally.

@a-ghorbani a-ghorbani marked this pull request as ready for review December 23, 2024 07:26
@a-ghorbani a-ghorbani merged commit f655ef3 into main Dec 23, 2024
2 of 3 checks passed
@a-ghorbani a-ghorbani deleted the chore/unify-preset-model-with-hf-model branch December 23, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant