Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace util.contains & util.merge_tables with builtin func… #11

Merged

Conversation

BBboy01
Copy link
Contributor

@BBboy01 BBboy01 commented Dec 18, 2024

Hi, I noticed there are some util functions are already built-in, we don't have to implement it again.

util.reverse can be replaced with vim.fn.reverse or vim.iter(list):rev():totable()

@aaronik aaronik changed the base branch from main to bboy-cleanup December 18, 2024 14:25
@aaronik aaronik merged commit afd341d into aaronik:bboy-cleanup Dec 18, 2024
1 check failed
@aaronik
Copy link
Owner

aaronik commented Dec 18, 2024

Well, I can tell you didn't run the tests, lol

But these are valuable insights. Thanks for your PR!

Just a note - lua.lua is a fixture file. You can never change stuff in a fixture file, because the tests are depending on it. :)

@aaronik
Copy link
Owner

aaronik commented Dec 18, 2024

Very serious question tho:

How do you get these cool things on your github? I want some too :D

Screenshot 2024-12-18 at 8 28 29 AM

@BBboy01
Copy link
Contributor Author

BBboy01 commented Dec 19, 2024

It's GitHub profile README

There are some APIs community provided, to pass your username and return an awesome image for Markdown to render.

Here is some refs:

Also, you can steal other user's README if you like his widget

@BBboy01
Copy link
Contributor Author

BBboy01 commented Dec 19, 2024

Well, I can tell you didn't run the tests, lol

lol, nice catch, sorry I am too confident

@BBboy01
Copy link
Contributor Author

BBboy01 commented Dec 19, 2024

https://github.com/yoshi389111/github-profile-3d-contrib

I just found a 3D versioned commit heat map

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants