Supports numbers of different bases #219
Conversation
|
@abice Please check out my PR |
example/example_diff_base.go
Outdated
| B6 = 0b110 | ||
| B7 = 0b111 | ||
| B8 = 0x08 | ||
| B9 = 0x09 |
There was a problem hiding this comment.
Can you add some values in here that contain non standard hex values (letters, specifically)
There was a problem hiding this comment.
I support not only hexadecimal values, but also binary and octal values.
There was a problem hiding this comment.
Right, just make sure that 0x0f and 0xff parse correctly into the right values.
| } else if strings.HasPrefix(value, "0") && len(value) > 1 { | ||
| return value[1:], 8 | ||
| } |
There was a problem hiding this comment.
I'm not sure I understand the benefit of this case. Do you mind elaborating a bit on why you would want this?
And what happens when you specify a value larger than the max?
There was a problem hiding this comment.
My intention is to support different representations of values in different binaries, in my project I usually use hexadecimal identifiers for these numbers, and if I convert to decimal for these values, it would be a problem to read the code. Of course, I could add comments to it and state the given value in the comments, but it feels like I'm adding to the problem.
There was a problem hiding this comment.
0XX is the number written in the base of the eight.
No description provided.