Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding license expression #142

Closed
wants to merge 2 commits into from
Closed

Adding license expression #142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
336d0e2
added the license Expression Library
Pratikrocks Mar 18, 2020
6acdbbf
Added the license expression library and made a small change of addin…
Pratikrocks Mar 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions etc/conf/dev/requirements_base.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,4 @@ coverage
pytest-cov
codecov
pytest-rerunfailures
pluggy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this added here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MaJuRG this was the extra requirements which was present in the License-expression Library,and regarding the .whl files it was present in the thirdparty folder of license expression library.I thaught these extra requirements and thirdparty .whl files would be required during configuration after adding license-expression library to the DeltaCode

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You would only need to add license_expression to the install_requires in setup.py.

The .whl files can be added to thirdparty, but these do not need to explicitly added to any requirements files

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes @MaJuRG ,it was my bad. Since .whl file of license_expression is already present in the thirdparty package it would be sufficient to add only license_expression in it install_requires in the setup.py

1 change: 0 additions & 1 deletion src/deltacode/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@
from deltacode import __version__
from deltacode.utils import deltas, get_notice, collect_errors


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this line removed?

def write_json(deltacode, outfile, all_delta_types=False):
"""
Using the DeltaCode object, create a .json file containing the primary
Expand Down
Loading