Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scancode-toolkit-mini and release prep v32.0.3 #3421 #3422

Merged
merged 8 commits into from
Jun 6, 2023

Conversation

AyanSinhaMahapatra
Copy link
Member

@AyanSinhaMahapatra AyanSinhaMahapatra commented Jun 6, 2023

Fixes #3421
Reference: aboutcode-org/skeleton#75

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁
  • Looked for possible updates in documentation and added updates if applicable
  • Updated CHANGELOG.rst

arijitde92 and others added 8 commits June 1, 2023 15:02
Made changes in the .readthedocs.yaml to enable format for downloading pdf and epub versions of the documentation and added latex_elements in the conf.py file which generates the pdf without blank pages. The minimum version requirement for sphinx was 6.2.1 which was causing build failure in read the docs, hence changing it 3.3.1 as written in setup.cfg of nexB/aboutcode

Signed-off-by: Arijit De <[email protected]>
Added PDF and ePub download option for RTD documentation as requested in aboutcode-org/aboutcode#127
Set the package name in setup-mini.cfg as scancode-toolkit-mini
to correctly generate the wheels.

Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Update the following actions:

* actions/checkout
* actions/setup-python

Reference: aboutcode-org/skeleton#75
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
@AyanSinhaMahapatra AyanSinhaMahapatra changed the title Fix scancode-toolkit-mini release #3421 Fix scancode-toolkit-mini and release prep v32.0.3 #3421 Jun 6, 2023
@AyanSinhaMahapatra
Copy link
Member Author

@pombredanne @JonoYang all green, ready to review.
See also https://github.com/AyanSinhaMahapatra/scancode-toolkit/actions/runs/5191401446 where I've tested the release scripts. I've also tested this locally and check any artifact like here: https://github.com/AyanSinhaMahapatra/scancode-toolkit/suites/13413534948/artifacts/734815144, they now contain both the wheels for scancode-toolkit and scancode-toolkit-mini.

@pombredanne
Copy link
Member

@AyanSinhaMahapatra I am not sure I get how this does fix the scancode-toolkit-mini build?

@AyanSinhaMahapatra
Copy link
Member Author

AyanSinhaMahapatra commented Jun 6, 2023

dd15f72#r116748649
@pombredanne see this ^ See also the description at #3421 (comment)
This commit: c205cee is the simple fix
😛 I should have spotted this too in #3207

Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ❤️ Thanks!

@AyanSinhaMahapatra
Copy link
Member Author

Thanks @pombredanne, merging!

@AyanSinhaMahapatra AyanSinhaMahapatra merged commit 3282bc0 into develop Jun 6, 2023
@AyanSinhaMahapatra AyanSinhaMahapatra deleted the release-prep-v32.0.3 branch June 6, 2023 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scancode-toolkit release is a scancode-toolkit-mini release
3 participants