Added support for package-lock.json to parse additional features #3988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…[email protected]> Signed-off-by: Varsha U N <[email protected]>
VarshaUN
force-pushed
the
support-package-lock.json
branch
from
381909f to
71453ba
Compare
There was a problem hiding this comment.
@VarshaUN are you sure what you are doing is correct?
- You are making changes to the package.json parser here, and not package-lock.json which was the target of issue Ensure we can collect the latest package-lock.json including file indirections for versions #3493
- Please add tests for each of the new functionality added so we can easily verify whether the code actually works and produces any useful data, use the github search with paths to look for useful examples.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3493
Tasks
Signed-off-by: Varsha U N [email protected]