Skip to content

Commit

Permalink
Fix path to aboutcode in utils_thirdparty.py #33
Browse files Browse the repository at this point in the history
    * Update README.rst

Signed-off-by: Jono Yang <[email protected]>
  • Loading branch information
JonoYang committed Sep 4, 2021
1 parent 944fbae commit 3532b22
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 2 deletions.
11 changes: 10 additions & 1 deletion README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,10 @@ requirements-dev.txt files.

Ensure the virtual environment is enabled.

.. code-block:: bash
source venv/bin/activate
To generate requirements.txt:

.. code-block:: bash
Expand All @@ -82,12 +86,17 @@ To generate requirements-dev.txt after requirements.txt has been generated:

.. code-block:: bash
./configure --init --dev
source venv/bin/activate
python etc/scripts/gen_requirements_dev.py -s venv/lib/python<version>/site-packages/
Collecting and generating ABOUT files for dependencies
------------------------------------------------------

Ensure that the dependencies used by ``etc/scripts/bootstrap.py`` are installed:

.. code-block:: bash
pip install -r etc/scripts/requirements.txt
Once we have requirements.txt and requirements-dev.txt, we can fetch the project
dependencies as wheels and generate ABOUT files for them:

Expand Down
2 changes: 1 addition & 1 deletion etc/scripts/utils_thirdparty.py
Original file line number Diff line number Diff line change
Expand Up @@ -2908,7 +2908,7 @@ def fetch_package_wheel(name, version, environment, dest_dir=THIRDPARTY_DIR):

def check_about(dest_dir=THIRDPARTY_DIR):
try:
subprocess.check_output(f'bin/about check {dest_dir}'.split())
subprocess.check_output(f'venv/bin/about check {dest_dir}'.split())
except subprocess.CalledProcessError as cpe:
print()
print('Invalid ABOUT files:')
Expand Down

0 comments on commit 3532b22

Please sign in to comment.