Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Windows] Update the scripts to fetch latest git version #11027

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[Windows] Update the scripts to fetch latest git version #11027

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
41ac292
Chnage Git Script
kishorekumar-anchala Nov 22, 2024
ed35d92
update checksum
kishorekumar-anchala Nov 23, 2024
65001d8
update dacfx checksum
kishorekumar-anchala Nov 23, 2024
8644efb
update the branch
kishorekumar-anchala Nov 24, 2024
ca8eb4e
Update the branch
kishorekumar-anchala Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 7 additions & 12 deletions images/windows/scripts/build/Install-Git.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,18 +4,13 @@
## Supply chain security: Git - checksum validation, Hub CLI - managed by package manager
################################################################################

# Install the latest version of Git for Windows

$downloadUrl = Resolve-GithubReleaseAssetUrl `
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By refusing to use a function, you lose some of the functionality, e.g. download retries. Instead of rewriting the script itself, it is better to fix the Resolve-GithubReleaseAssetUrl function

-Repo "git-for-windows/git" `
-Version "latest" `
-UrlMatchPattern "Git-*-64-bit.exe"

$externalHash = Get-ChecksumFromGithubRelease `
-Repo "git-for-windows/git" `
-Version "latest" `
-FileName (Split-Path $downloadUrl -Leaf) `
-HashType "SHA256"
# Fetch the latest release info from GitHub API
$response = Invoke-RestMethod -Uri "https://api.github.com/repos/git-for-windows/git/releases/latest"
$asset = $response.assets | Where-Object { $_.name -match "Git-.*-64-bit.exe" }

# Download URL and SHA256 checksum
$downloadUrl = $asset.browser_download_url
$externalHash = "83c618dcc50b63f0f7afc86a7a125169bd59559ff680683f1d915c45e05ff4cc"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need to hardcode the hash if it can be obtained automatically.


Install-Binary `
-Url $downloadUrl `
Expand Down