Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle converting pr to/from draft #13

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Conversation

matt-fidd
Copy link
Collaborator

The assumptions made here are:

  • if a PR is a draft, we don't need the [WIP] title prefix
  • if a PR is a draft, it will always be considered WIP so needs the WIP label
  • if a PR is converted from a draft, it should be considered ready for review, and should update as such
  • if a PR is converted back to a draft, it should drop the prefix for consistency and revert back to the WIP label
  • if a PR is a draft we don't check for failing CI

@matt-fidd matt-fidd requested a review from twk3 July 7, 2024 23:28
@actual-github-bot actual-github-bot bot changed the title handle converting pr to/from draft [WIP] handle converting pr to/from draft Jul 7, 2024
@matt-fidd matt-fidd changed the title [WIP] handle converting pr to/from draft handle converting pr to/from draft Jul 7, 2024
src/handlers/pullRequest.ts Outdated Show resolved Hide resolved
src/handlers/pullRequest.ts Outdated Show resolved Hide resolved
@matt-fidd
Copy link
Collaborator Author

matt-fidd commented Jul 8, 2024

I've addressed your comments, not my finest work hardcoding a length in when it used a regex to match the bit I was removing anyway!

I've also extended the regex to match other common patterns that were previously handled in Trafico so as not to break any folk's existing workflow.

Copy link
Contributor

@twk3 twk3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks @matt-fidd !

@matt-fidd matt-fidd merged commit 9e1f8a2 into actualbudget:main Jul 9, 2024
2 checks passed
@matt-fidd matt-fidd deleted the draft branch July 9, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants