Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce frequency of label presence checks #14

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

matt-fidd
Copy link
Collaborator

Fixes #11

This reduces the amount of times that the repo is checked to make sure the required labels are configured properly.

Runs on the following targets:

  • New installation
  • Installation is reinstated after being suspended
  • New permissions are accepted (permission change is likely to come with a change to the labels)
  • New repositories are added to the installation

I've selected these manually instad of a catch all as there's no need to run when repositories are deauthed, the installation is deleted/suspended and so on...

Consideration:

  • If a new label is added without any of the above triggers, the label will be added to the repo on the next run it applies to, but will be not have the correct colour and will need to be fixed manually.

@matt-fidd matt-fidd requested a review from twk3 July 8, 2024 00:03
@actual-github-bot actual-github-bot bot changed the title reduce frequency of label presence checks [WIP] reduce frequency of label presence checks Jul 8, 2024
@matt-fidd matt-fidd changed the title [WIP] reduce frequency of label presence checks reduce frequency of label presence checks Jul 8, 2024
@matt-fidd
Copy link
Collaborator Author

Aha, there's a bug!

@matt-fidd
Copy link
Collaborator Author

Aha, there's a bug!

Fixed in #15

@twk3
Copy link
Contributor

twk3 commented Jul 8, 2024

@matt-fidd looks good. If we need to fix a repo's labels we can always suspend and unsuspend.

@matt-fidd matt-fidd merged commit f68df57 into actualbudget:main Jul 8, 2024
2 checks passed
@matt-fidd matt-fidd deleted the reduce-label-check branch July 8, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

less frequent calls to the repo label management
2 participants