Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix push user detection #25

Merged
merged 1 commit into from
Aug 14, 2024
Merged

fix push user detection #25

merged 1 commit into from
Aug 14, 2024

Conversation

matt-fidd
Copy link
Collaborator

This fixes the issues reported in #23

The root cause was that only the owner of the repository was returned in this.octokit.repos.listCollaborators, I assume due to the fact that maintainers are given access at org level as opposed to repo level.

I've removed the logging that was added to debug.

@matt-fidd matt-fidd requested a review from twk3 August 14, 2024 17:34
@actual-github-bot actual-github-bot bot changed the title fix push user detection [WIP] fix push user detection Aug 14, 2024
@matt-fidd matt-fidd changed the title [WIP] fix push user detection fix push user detection Aug 14, 2024
Copy link
Contributor

@twk3 twk3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks @matt-fidd !

@matt-fidd matt-fidd merged commit cc9bfa1 into main Aug 14, 2024
3 checks passed
@matt-fidd matt-fidd deleted the matt-fidd/fix-push-users branch August 14, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants