Do not re-enable the timer when the user request a PWM frequency of 0. #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evtimDev
reviewed
Jul 27, 2022
| enableTimer(p.tc); | ||
| if (freq > 0){ | ||
| enableTimer(p.tc); | ||
| } | ||
| #ifdef USE_TCC_TIMERS | ||
| } | ||
| else{ |
There was a problem hiding this comment.
USE_TCC_TIMERS is the default for samd21. Should the else section be updated here as well? Does currently samd21 emit any PWM when frequency is set to 0?
There was a problem hiding this comment.
I don’t know, I don’t have a SAMD21 device to test the behavior, that’s why I didn’t change it.
If you think that it should be changed too I can update the code there, otherwise I would prefer to leave it to someone who can actually test it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a tentative fix for for issue #55. I tested that this fix it on a SAMD10 chip (that, setting the PWM freq to 0 will now fully stop the PWM output). I did not test it on SAMD09 or SAMD21 chips (as I don’t have compatible hardware to test).
I’m not entirely convinced by this PR, because it might be more logical to stop the output with a call to setting the PMW value rather than the frequency. However, the current
PWMWritemethod in the firmware does not disable the PMW output (as opposed to thesetFreqmethod that I’m changing), so this PR is a smaller change.