Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ports/mimxrt10xx/boards: Add board files for Seeed ARch Mix, Olimex RT1011 and Makerdiary RT1011 Nano Kit.. #414

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

robert-hh
Copy link
Contributor

Boards:

  • Seed Arch Mix RT1052
  • Olimex RT1011
  • Makerdiary RT1011 Nano Kit

All sets differ only slightly from the respective imxrt10xx-evk files. Major changes are flash size and LED pin. All have been tested with theses boards.

Copy link
Member

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR, everything look goods, there is a minor request to change board-id to match uf2 specs format.

Also I have a question regarding VID/PID, are these assigned specifically for these board for bootloader purpose and re-use/shared with other application/board.

#define USB_PRODUCT "iMX RT1011 Nano Kit"

#define UF2_PRODUCT_NAME USB_MANUFACTURER " " USB_PRODUCT
#define UF2_BOARD_ID "iMX RT1011 Nano Kit"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should follow the board-id format https://github.com/microsoft/uf2?tab=readme-ov-file#files-exposed-by-bootloaders

UF2 Bootloader v1.1.3 SFA
Model: Arduino Zero
Board-ID: SAMD21G18A-Zero-v0

The Board-ID field is machine-readable and consists of a number of dash-separated tokens. The first token is the CPU type, second is the board type, and third is the board revision. More tokens can be also added.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the hint about the board ID structure. I'll change them accordingly.

#define USB_PRODUCT "RT1010"

#define UF2_PRODUCT_NAME USB_MANUFACTURER " " USB_PRODUCT
#define UF2_BOARD_ID "Olimex-RT1010"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above board id format

@robert-hh
Copy link
Contributor Author

The VID/PID are set on best knowdledge.
Olimex RT1011: PID and VID have been supplied by the vendor and are set by the APP as well.
Makerdiary RT1010 Nano Kit: The VID/PID are the values shown in their bootstrap loader. So I use the same here, even if the VID is one of Seeed Technologies.
Seeed Arch Mix: 0x2886 is tve VID of Seeed. No specific PID was supplied by the vendor. But I can ask.

@hathach
Copy link
Member

hathach commented Oct 11, 2024

The VID/PID are set on best knowdledge. Olimex RT1011: PID and VID have been supplied by the vendor and are set by the APP as well. Makerdiary RT1010 Nano Kit: The VID/PID are the values shown in their bootstrap loader. So I use the same here, even if the VID is one of Seeed Technologies. Seeed Arch Mix: 0x2886 is tve VID of Seeed. No specific PID was supplied by the vendor. But I can ask.

I guess olimex and makerdiary is OK, for Seed Arch, maybe if you could just ask to see if they allocated any PID for the board (you can @ their developer here know one).

@gsteiert
Copy link
Collaborator

gsteiert commented Oct 11, 2024 via email

@robert-hh
Copy link
Contributor Author

I guess olimex and makerdiary is OK, for Seed Arch, maybe if you could just ask to see if they allocated any PID for the board (you can @ their developer here know one).

I asked both Makerdiary and Seeed. Makerdiary swiftly responded that 0x2886/0xf00f is the right one. The have an agreement with Seeed. Seeed did not respond yet about the Arch Mix board. Maybe on Monday,

@robert-hh
Copy link
Contributor Author

@hathach Seeed responded and told me, that they cannot tell me a PID for the Arch Mix board. Maybe they never assigned one, or they could not find the number. The board I have is not any more in the delivery state, so I cannot just check. Anyhow I've set it to 0x0010. Maybe 0x1052 would be a good number as well.

@hathach
Copy link
Member

hathach commented Oct 14, 2024

I requested NXP set aside a VID/PID that could be used for generically for UF2. I would suggest using that for UF2 on NXP based boards. Otherwise you always need two PID if your application has a different USB configuration than UF2. Greg

That sounds great, do you think that makes sense to ask for a PID per mcu since they are a bit different from each other. Though I think a general one for imxrt is OK as well for board that does not has a private PID. Btw, @gsteiert since you are here, do you happen to know if there is any issue with imxrt1015, robert only get it working when compiled with gcc v10 #413 (reply in thread) . I forgot the detail, but could look at this later if you don't have time.

@hathach Seeed responded and told me, that they cannot tell me a PID for the Arch Mix board. Maybe they never assigned one, or they could not find the number. The board I have is not any more in the delivery state, so I cannot just check. Anyhow I've set it to 0x0010. Maybe 0x1052 would be a good number as well.

The rule of thumb is making sure that the VID/PID is valid and unique if possible (not conflicting with other existing device whose vid/pid is owned by other). If your PID for seed it not used elsewhere then I think we are good with since I think seed agree for you to use their VID. Otherwise we can also wait for greg (FAE from NXP) to see if he could get an generic PID from NXP.

Copy link
Member

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there seems a typo in port.mk

ports/mimxrt10xx/port.mk Outdated Show resolved Hide resolved
- Seed Arch Mix RT1052
- Olimex RT1011
- Makerdiary RT1011 Nano Kit

All differ only slightly from the respective mimxrt10xxevk files.
Major changes are flash size and LED pin. All have been tested
with theses boards.

Signed-off-by: robert-hh <[email protected]>
Copy link
Member

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect, thank you

@hathach hathach merged commit 9eb165c into adafruit:master Oct 22, 2024
137 checks passed
@robert-hh
Copy link
Contributor Author

Thank you very much.

@hathach
Copy link
Member

hathach commented Oct 23, 2024

you're welcome, I am still stuck with dwc2 host driver for the time being. Will test out the imxrt1015 later on when possible

@robert-hh
Copy link
Contributor Author

Do not hurry. The imxrt1015 is not important, unless it indicates a general problem.

@robert-hh robert-hh deleted the more_boards branch November 3, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants