Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage watchfiles settings #10

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Manage watchfiles settings #10

wants to merge 4 commits into from

Conversation

q0w
Copy link

@q0w q0w commented Sep 2, 2022

I've replaced autoreload.get_reloader with autoreload.run_with_reloader to get verbosity level to setup debug mode. Other settings you can get from the project settings WATCHFILES, e.g.:

WATCHFILES = {
    'watch_filter': 'path.to.custom_filter',
    'raise_interrupt': False,
    'debug': False,
}

@q0w q0w marked this pull request as ready for review September 2, 2022 18:11
hooks:
- id: pyupgrade
args: [--py37-plus]
- repo: https://github.com/psf/black
rev: 22.1.0
rev: 22.8.0
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated pre-commit hooks since black 22.1.0 was broken

@james-certn
Copy link

@adamchainz This looks like a solid contribution. Does this align with your vision for the project?

@Majsvaffla
Copy link

Very much thumbs up for this 👍

It's practically unusable for me without this patch. I get like an endless amount of debug output even when I haven't changed a file. We started using this at work and my colleagues doesn't experience the same problem as me though.

@flbraun
Copy link

flbraun commented Jun 28, 2023

Great contribution! Looking forward to release. IMO this is the key part missing to give django-watchfiles a decent developer experience.

@flbraun
Copy link

flbraun commented Sep 11, 2023

@adamchainz Could you please take a look at this PR and give your feedback? It's been open for a year now and is a blocker for me and other people to adopt django-watchfiles. Thank you!

@shapiromatron
Copy link

If changes were reverted from the .pre-commit-config.yaml would that help with getting this merged in? I would be happy to help or submit a second PR with reduced scope if that would be useful. @adamchainz @flbraun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants