-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Heroku-ready version of Staytus #240
Open
ideasasylum
wants to merge
14
commits into
adamcooke:master
Choose a base branch
from
ideasasylum:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
I'm running your fork on Heroku... and it's working well (except e-mails)! 😄 |
is this merged? if not, any reason? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First: This is something of an experiment rather than a PR that can be merged.
I wondered what it would take to make Staytus deployable to Heroku using a Heroku Button. It came down to:
You can try the Heroku button here in my fork's README
I've got no interest in maintaining a Heroku-specific fork, and I'm not even sure I have a use for Staytus right now, but I wondered if there was a way to have a single repo with both mysql and postgres dependancies? I'm not sure how this would work. Could an environment variable change which adapter is loaded? But how do we keep schema.rb database-agnostic?
Maybe some other interested and knowledgeable parties will find this and comment.