Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to set image margin #44

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

jdugge
Copy link
Contributor

@jdugge jdugge commented Aug 19, 2016

It can sometimes be helpful to extend the texture of a model beyond the island edges. That way, even if the cuts aren't completely precise, no white gaps become visible. This commit makes the rd.bake_margin property available in the UI.

@addam
Copy link
Owner

addam commented Aug 22, 2016

I have personally removed this option a few years ago because the margin-ed images somewhat confuse the shape of the net, and because I try to keep all the switches and buttons to a minimum. Also, paper is white on cross-cut, so I usually paint over the edges anyway.
Have you tried making some models with this margin, are you sure it helps?

@jdugge
Copy link
Contributor Author

jdugge commented Aug 22, 2016

In my experience, having the margins helps a lot. However, this is probably at least in part due to the fact that I use invisible edge lines because I cut the models using a digital cutting machine, and without the margin the pixelated edge of the texture always shows:

img_20160822_203327

Maybe it would be possible to tuck away such specialised options in an "Advanced Settings" section that is collapsed by default?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants