Merge pull request #410 from adevinta/fix/checkbox/403_text_alignment

[Fix#403] Align top of controlView to top of text on checkbox
adevinta · Sep 1, 2023 · 79d4cf9 · 79d4cf9
2 parents b84d868 + 3270095
commit 79d4cf9
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/core/Sources/Components/Checkbox/View/UIKit/CheckboxUIView.swift b/core/Sources/Components/Checkbox/View/UIKit/CheckboxUIView.swift
@@ -311,7 +311,7 @@ public final class CheckboxUIView: UIView {
             self.controlViewTrailingConstraint = controlView.trailingAnchor.constraint(equalTo: view.safeAreaLayoutGuide.trailingAnchor, constant: padding)
             self.controlViewTrailingConstraint?.isActive = true
         }
-        let controlViewCenterConstraint = controlView.centerYAnchor.constraint(equalTo: textLabel.centerYAnchor)
+        let controlViewCenterConstraint = self.textLabel.heightAnchor.constraint(greaterThanOrEqualTo: self.controlView.heightAnchor)
         controlViewCenterConstraint.isActive = true
 
         self.button.addTarget(self, action: #selector(self.actionTapped(sender:)), for: .touchUpInside)

diff --git a/core/Unit-tests/Resources/IconographyTests.xcassets/checkbox-selected.imageset/Contents.json b/core/Unit-tests/Resources/IconographyTests.xcassets/checkbox-selected.imageset/Contents.json
@@ -1,7 +1,7 @@
 {
   "images" : [
     {
-      "filename" : "Path.svg",
+      "filename" : "check-fill.svg",
       "idiom" : "universal"
     }
   ],

diff --git a/...t-tests/Resources/IconographyTests.xcassets/checkbox-selected.imageset/Path.svg b/...t-tests/Resources/IconographyTests.xcassets/checkbox-selected.imageset/Path.svg
diff --git a/...s/Resources/IconographyTests.xcassets/checkbox-selected.imageset/check-fill.svg b/...s/Resources/IconographyTests.xcassets/checkbox-selected.imageset/check-fill.svg