Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the slice sorting functions
sort_unstable
,sort_unstable_by
andsort_unstable_by_key
.These functions currently all take
&mut self
in order to make sure we have full control over the vector.I added debug assertions around the borrow fields to check with you what to do - I assume the functions could return an error instead of panicking if any borrow currently exists.
The safety argument is that since no elements are currently borrowed, the vector is mutably borrowed itself and the length of the vector is not changed during the operation, we can safely access the individual elements without requiring a clone out of the cell.
The two functions
sort_unstable_by
andsort_unstable_by_key
cannot be expressed in terms of each other due to the requirementT: Ord
on only one of them, so I had to implement them twice. I sadly couldn't link the documentation to[T]::sort_unstable
etc. due to issue rust-lang/rust#62968 and related.