add stars nouns & celestial adjectives #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several enhancements and updates to the project, including new data, updated documentation, and additional test cases. The main changes involve the addition of new adjectives and nouns, updates to the README and types, and new test cases to ensure the correctness of the new data.
New Data Additions:
data/adjectives/celestial.json: Added a comprehensive list of celestial adjectives.data/nouns/stars.json: Added a comprehensive list of star nouns.Documentation Updates:
README.md: Added a new section on how to add data, emphasizing the naming convention for noun files.CHANGELOG.md: Documented the changes for version 1.1.0, including the addition of celestial adjectives and star nouns, and updates to the README and types.Code Updates:
index.ts: UpdatedAdjectiveTypeandNounTypeto include 'celestial' and 'star', respectively.Test Enhancements:
__tests__/index.test.ts: Added new test cases to handle combinations involving celestial adjectives and star nouns, and ensured different combinations are generated correctly.Version Update:
package.json: Updated the version to 1.1.0 to reflect the new changes.