Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support data client side #4

Merged
merged 3 commits into from
Jul 31, 2024
Merged

Conversation

aflansburg
Copy link
Owner

Description

This pull request includes several changes to the build scripts and configuration to improve the handling of data files. The main changes involve copying data files to both the dist and public directories, and updating the package.json to reflect these changes.

Changes to data file handling:

Updates to package.json:

  • package.json: Added a postinstall script to run the new copyDataToPublic.js script after installation.
  • package.json: Updated the files field to include the dist and dist/data directories.

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Adds data for nouns & adjectives
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works, including tests for any new nouns or adjectives
  • New and existing unit tests pass locally with my changes

Additional context

Add any other context about the pull request here.

@aflansburg aflansburg merged commit 6b46e49 into main Jul 31, 2024
1 of 2 checks passed
@aflansburg aflansburg deleted the support-data-client-side branch July 31, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant