include symlink destination in path info (#169)

* Include symlink destination in path info. The existing `parse_list_line_unix` function goes to all the work of parsing symlink lines, but omits the actual destination of the symlink. This tiny change adds parsed destination to the path's info dictionary. * add tests for `link_dst` info key --------- Co-authored-by: pohmelie <[email protected]>
aio-libs · Dec 11, 2024 · 0dda701 · 0dda701
1 parent 8453684
commit 0dda701
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/src/aioftp/client.py b/src/aioftp/client.py
@@ -482,6 +482,7 @@ def parse_list_line_unix(self, b):
             link_src = s[:i]
             i = -2 if link_dst[-1] == "'" or link_dst[-1] == '"' else -1
             info["type"] = "dir" if link_dst[i] == "/" else "file"
+            info["link_dst"] = link_dst
             s = link_src
         return pathlib.PurePosixPath(s), info
 

diff --git a/tests/test_simple_functions.py b/tests/test_simple_functions.py
@@ -186,6 +186,14 @@ def test_parse_list_line_unix():
     with pytest.raises(ValueError):
         p(b"-rw-rw-r--  xx poh  poh   6595 Feb 27 04:14 history.rst")
 
+    _, parsed = p(b"lrwxrwxrwx  1 poh  poh      6 Mar 23 05:46 link-tmp.py -> tmp.py")
+    assert parsed["type"] == "file"
+    assert parsed["link_dst"] == "tmp.py"
+
+    _, parsed = p(b"lrwxrwxrwx  1 poh  poh      6 Mar 23 05:46 link-tmp.py -> /tmp.py")
+    assert parsed["type"] == "file"
+    assert parsed["link_dst"] == "/tmp.py"
+
 
 @pytest.mark.parametrize("owner", ["s", "x", "-", "E"])
 @pytest.mark.parametrize("group", ["s", "x", "-", "E"])