Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fix ipv4 override test #175

Merged
merged 2 commits into from
Mar 14, 2024
Merged

tests: fix ipv4 override test #175

merged 2 commits into from
Mar 14, 2024

Conversation

pohmelie
Copy link
Collaborator

What do these changes do?

Are there changes in behavior for the user?

Related issue number

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes

@pohmelie
Copy link
Collaborator Author

@9en9i check code from this PR on MacOS for the timeout error in tests

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.99%. Comparing base (8ac1792) to head (98a4f3e).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #175   +/-   ##
=======================================
  Coverage   98.99%   98.99%           
=======================================
  Files           6        6           
  Lines        1897     1897           
=======================================
  Hits         1878     1878           
  Misses         19       19           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@9en9i
Copy link

9en9i commented Mar 14, 2024

@pohmelie Now all the tests have been passed

@pohmelie pohmelie merged commit 3550877 into master Mar 14, 2024
18 checks passed
@pohmelie pohmelie deleted the fix/ipv4-override-test branch March 14, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants