Backport HashedWheelTimerFix to .NET Standard 2.0

Port #7174 to .NET Standard 2.0
akkadotnet · Apr 29, 2024 · b93c479 · b93c479
1 parent 9c63bfe
commit b93c479
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/src/core/Akka/Actor/Scheduler/HashedWheelTimerScheduler.cs b/src/core/Akka/Actor/Scheduler/HashedWheelTimerScheduler.cs
@@ -248,8 +248,10 @@ private void ProcessReschedule(long now)
 
         private void Start()
         {
-            if (_workerState == WORKER_STATE_STARTED) { } // do nothing
-            else if (_workerState == WORKER_STATE_INIT)
+            // only read the worker state once so it can't be a moving target for else-branch
+            var workerStateRead = _workerState;
+            if (workerStateRead == WORKER_STATE_STARTED) { } // do nothing
+            else if (workerStateRead == WORKER_STATE_INIT)
             {
                 _worker ??= new Thread(Run) { IsBackground = true };
                 if (Interlocked.CompareExchange(ref _workerState, WORKER_STATE_STARTED, WORKER_STATE_INIT) ==
@@ -258,7 +260,7 @@ private void Start()
                     _worker.Start();
                 }
             }
-            else if (_workerState is WORKER_STATE_SHUTDOWN)
+            else if (workerStateRead is WORKER_STATE_SHUTDOWN)
             {
                 throw new SchedulerException("cannot enqueue after timer shutdown");
             }