WIP: Add Heex and Phoenix.Component support #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This WIP PR tries to add support for HEEX templates and Phoenix.Components to mjml_eex.
I managed to add basic support for both, but I'd like to discuss the approach with you.
Heex support
Interestingly, I could simply change the file extension from
.eexto.heexand all templates were still compiled.This doesn't activate all Heex validations though. For example, there are no compile-time validations for forgotten closing tags yet, but MJML throws an exception at runtime anyways.
Phoenix Component
I managed to render Phoenix Components that render Heex templates inside the MJML templates. They also check at runtime that all required variables are given. Again, this doesn't happen at compile-time.
Other
I added a small paragraph to the Readme, because I was blocked from committing because I didn't know I had to run
mix git_hooks.installfirst.