Branch for upgrade to DataFusion March 5 Upgrade #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… dictionaries (apache#9679) * Add test for multiple count distincts on a dictionary * Fix accumulator merge bug * Fix cleanup code
…r common subexpr elimination optimization (apache#9685) * test(9678): reproducer of short-circuiting causing expr elimination to error * fix(9678): populate visited stack for short-circuited expressions, during the common-expr elimination optimization * test(9678): reproducer for optimizer error (in common_subexpr_eliminate), as seen in other test case * chore: extract id_array into abstraction, to make it more clear the relationship between the two visitors * refactor: tweak the fix and make code more explicit (JumpMark, node_to_identifier) * fix: get the series_number and curr_id with the correct self.current_idx, before the various incr/decr * chore: remove unneeded conditional check (already done earlier), and add code comments * Refine documentation in common_subexpr_eliminate.rs * chore: cleanup -- fix 1 doc comment and consolidate common-expr-elimination test with other expr test --------- Co-authored-by: Andrew Lamb <[email protected]>
alamb
pushed a commit
that referenced
this pull request
Jul 24, 2024
* Configurable date field extraction style for unparsing (apache#21) * Add support for IntervalStyle::MySQL (#18) * Support alternate format for Int64 unparsing (SIGNED for MySQL) (apache#22) * Alternate format support for Timestamp casting (DATETIME for MySQL) (apache#23) * Improve * Fix clippy and docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is used to visualize the https://github.com/alamb/arrow-datafusion/tree/alamb/march_5_patched
patched fork of DataFusion that we are using upstream in InfluxDB 3.0
This PR targets a branch in this repo that has the target DataFusion commit ea01e56 from March 5, 2024
Note: I do not intend to merge this PR.
This branch contains two fixes:
Fix 1: Count Distinct:
apache#9679 / apache@3c3b228
Fix 2: Treenode alias rewrite:
apache#9685 / apache@5f0cb49
It was created with these commands:
git checkout ea01e56c3341dd4308a24e94091b86ee475ce224 git checkout -b alamb/march_5_base git push -u alamb git checkout -b alamb/march_5_patched git cherry-pick 3c3b22866a7ece784208e9d499119b2e13399762 git cherry-pick 5f0cb49c8b1a47830d80a7add1d3c96d7d5a0025 # resolved merge conflicts git cherry-pick --continue