Add support for ActiveJob #38
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
github is being odd and not showing the rebuild that travis ran: https://travis-ci.org/github/alanpeabody/resque-job-stats/builds/672765041 |
|
Seems like this works for enqueued and performed but not the other statistics? Specifically I think you need to include the |
|
will try to have a look at this PR this weekend |
|
Hey @lukeasrodgers is it any chance that you'll have a time to take a look at this MR? Or maybe I can help with it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were trying to use this gem and realized it was working for normal resque jobs but not for ActiveJob jobs. The main difference seems to be ActiveJob has
#performas an instance method, not a class method - and ActiveJob doesn't support all the magical callbacks based on the method being named something likeafter_perform_foobar. Both of these issues are alleviated by this PR. My test passes at least, I will update our application locally to pull from my fork to confirm the tracking is doing what we expect and will report back here.