-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: table supports the use of attributes #420
Conversation
|
src/table/table.component.ts
Outdated
@@ -26,7 +26,7 @@ import { | |||
} from './table-placeholder.directive'; | |||
|
|||
@Component({ | |||
selector: 'aui-table', | |||
selector: 'aui-table,[aui-table]', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
拆成一个新的组件作为后续重构的基础,selector用table[auiTable],限定宿主必须是table元素,属性选择器都用camleCase。其他几个选择器也这样改
src/table/table.component.scss
Outdated
|
||
.aui-table { | ||
&__row, | ||
&__header-row { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aui-table__row不是用在tr元素上的么,为什么还要改display
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
改成table-row以覆盖标签使用方式的flex布局
src/table/table.component.scss
Outdated
} | ||
} | ||
|
||
tbody { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
嵌套了table咋办,保持用bem class设样式
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这些样式属于重置,不是设定自定义样式的
211a0f0
to
1f28cd6
Compare
|
||
/** Cell template container that adds the right classes and role. */ | ||
@Directive({ | ||
selector: '[auiTableCell]', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不需要限制宿主是td?
1f28cd6
to
823199c
Compare
823199c
to
23a3256
Compare
23a3256
to
116c3c6
Compare
116c3c6
to
e35eaad
Compare
close #419