Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a unique output dir per set of source files #28

Merged
merged 1 commit into from
Sep 28, 2024

Conversation

albertocavalcante
Copy link
Owner

marcohu#23 (comment)

This is an attempt to make multiple rules_antlr invocations work without sandboxing (eg on Windows, where there's no sandbox). Test with --spawn_strategy=local.

Before, the AntlrRules.java code would fail, as it'd find generated grammar files without sandboxing it didn't know about.
Fix this by providing a unique directory per grammar that's being compiled.
The code that throws the exception is master/src/main/java/org/antlr/bazel/AntlrRules.java#L619.

This is an attempt to make multiple rules_antlr invocations work
without sandboxing (eg on Windows, where there's no sandbox).
Test with --spawn_strategy=local.
@albertocavalcante albertocavalcante merged commit 56242f1 into albertocavalcante:main Sep 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants